Properties dialogue: REVOKE goes wrong in certain cases.

[brsa]

Testcase to reproduce - execute as superuser postgres:

CREATE ROLE blob;
CREATE ROLE blob_read;
CREATE TABLE test (t integer PRIMARY KEY);
GRANT SELECT ON TABLE test TO blob_read; -- note the underscore!
GRANT SELECT ON TABLE test TO blob; -- note how this role's name is identical up to the underscore! Note also, that this GRANT comes after the one before.

Open properties dialog on table, chose "Privileges" rider.
You see 3 users that have privileges:

postgres arwdDxt
blob_read r
blob r

Now try to delete "blob_read". (mark, click [Remove], click [OK]).
!The wrong role gets deleted!

Actually, that is what the server gets. All 3 commands are wrong / nonsensical!

REVOKE ALL ON TABLE test FROM GROUP blob;
GRANT SELECT ON TABLE test TO GROUP blob;
REVOKE ALL ON TABLE test FROM GROUP blob;

The bug only occurs if blob_read appears before blob in the list of privileges.
I have tried to pin down this one for a while now, but it was extremely hard to pin down. Present in 1.12.2 as well as 1.12.3 (pre-release).

Maybe underscores in role-names confuse the algorithm .. ?

[gleu]

Fixed in  http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commit;h=104bdc80488fc05f51335e4a5b8c7e5bb8c7ad51 and  http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commit;h=196e0a815d6e229455612aed2b92e3154c3ef645

[gleu]

Milestone 1.12.4 deleted